Improved pull request "Files Changed" experience feedback #163932
Replies: 3052 comments 1263 replies
-
|
I would like to be able to scroll through the Pull Request while the comment modal is open. Reason: When a comment is outdated, we need to look at the current version to check if it actually addresses the comment. I really love this feature! THANK YOU!!! |
Beta Was this translation helpful? Give feedback.
-
|
Update: I just found out that it appears when there's enough space (1280px width). Here's the updated feedback. I'd like to see the branch name in the sticky header at all times so that I can easily copy it when I'm reviewing a PR. I wrote the following before thoroughly experimenting. I'd like to see the branch name when the sticky header is shown (i.e., when you've scrolled to the bottom). The reason is that when I'm reviewing a long PR and want to checkout the branch to continue reviewing it locally, I have to go back all the way up to see or copy the branch name and then go back to where I left off. |
Beta Was this translation helpful? Give feedback.
-
|
I find the comment indicators in the sidebar really useful. It might also be useful to have them in the "diff file header." It's very useful when you've marked a file as "viewed" because you can see how many comments it has as you're scrolling without having to expand it. |
Beta Was this translation helpful? Give feedback.
-
This is really cool. Is it also possible to seamlessly toggle hiding white spaces? If that's achievable without doing a refresh would be amazing. |
Beta Was this translation helpful? Give feedback.
-
|
Clicking a line number always assumes you want to add a comment. In the previous experience it only changes the URL to have deep linking. |
Beta Was this translation helpful? Give feedback.
-
|
This is so much better, I might go back from reviewing with the VSCode extension now 🚀 I love the new alerts panel, unfortunately it looks like pressing Maybe we could have some grouping or clustering in the alerts panel in the future. |
Beta Was this translation helpful? Give feedback.
-
|
I would love to see the file tree sorted alphabetically with folders on top, then files. It is quite jarring to have changed files in the middle of folders when viewing the file tree currently. Example of current state Example of desired state This would mirror how the majority of developers view the code in their IDE |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
Hi, I would like to play around with this, but I'm not seeing the opt-in mentioned in
Am I missing something? |
Beta Was this translation helpful? Give feedback.
-
|
The tab for |
Beta Was this translation helpful? Give feedback.
-
|
Not sure if this is the sort of feedback you're after, but the |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
On the Files changed tab I can only see 19 files out of 66. Why? |
Beta Was this translation helpful? Give feedback.
-
|
I used to be able to click on a useful link to see the submodule diff in PRs but now its just plain text. Could we have that back pls? |
Beta Was this translation helpful? Give feedback.
-
|
It doesn't always seem to remember if hide whitespace was turned on. |
Beta Was this translation helpful? Give feedback.
This comment was marked as spam.
This comment was marked as spam.
-
|
In the file sidebar I should be able to mark all files within a directory as seen with a single click |
Beta Was this translation helpful? Give feedback.
-
|
total disaster, it is literally impossible to review PR that has more than 20 file changes. also as whole github web, comments are on the bottom even though i need to scroll for 1 min to finally reach it. |
Beta Was this translation helpful? Give feedback.
-
|
Some of the projects I work on have a lot of generated files. These are committed, and reviewed, but it would be handy to be able to easily filter them out during code review, so that you can review the manual edits separate from the generated edits. |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
-
|
NOTHING ❤️ |
Beta Was this translation helpful? Give feedback.
-
|
The new PR review experience is faster and cleaner, but the forced single-file review mode hurts productivity in large PRs. Reviewing related files side-by-side or through continuous scrolling was much easier in the old experience. Would love to see:
The new sidebar indicators, pending review panel, and reduced reloads are great improvements though. |
Beta Was this translation helpful? Give feedback.
-
|
https://github.com/orgs/community/discussions/163932#discussioncomment-15850025 |
Beta Was this translation helpful? Give feedback.
-
|
i am not quite sure what is coursing this, since the behavior is in the new and old PR-View. But currently the Web-view of a PR is no longer updating, when the underling Branch got updated. it continues to show the state from when the PR was created. You can no longer esaily see if the requested changes where made. |
Beta Was this translation helpful? Give feedback.
-
|
Files changed view seems unsure whether it should give me review comments or hide them. I am confused. Toggling from new to old and back made comments visible again?! I need stable tools, this feels flaky right now. |
Beta Was this translation helpful? Give feedback.
-
|
@Akash1134 might be worth adding another "update" - as I am now seeing this in our Cloud based - GitHub Enterprise 🎉 so thankful! It's SOOO much better! Especially scrolling file changes is buttery smooth, instead of the browser crashing - this is huge for us! Thank you! |
Beta Was this translation helpful? Give feedback.
This comment was marked as disruptive content.
This comment was marked as disruptive content.
-
Beta Was this translation helpful? Give feedback.
-
|
🐛 when you press a deep link to a resolved comment, instead of opening the resolved comment you are stuck at the top of the PR. |
Beta Was this translation helpful? Give feedback.
-
|
Feature request: Show code owner team labels per file in the file tree The "Only files owned by you" filter is great for reviewers, but PR authors have no way to see which code owner team maps to which file in their PR. The problem: In large monorepos with distributed ownership (ours has 15+ teams in CODEOWNERS), a PR author sees 3-4 teams requested at the top of the PR but can't tell which files triggered which team. This makes it hard to: Know who to proactively reach out to |
Beta Was this translation helpful? Give feedback.



















Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
About the new experience
This updated experience focuses on performance, accessibility, and user productivity. Read more in the changelog.
Tip
If you are not already using the new experience, click the ✨Try the new experience in the upper-right corner of the classic "Files changed" page. You can easily switch back from the Preview menu.
✨ What's new
If you are coming from the classic experience, the new experience should feel familiar but adds some significant improvements:
✨ Updates
See what's been fixed and improved since the launch of the public preview:
🟡 Limitations
As of the initial public preview release, there are some temporary limitations that will be addressed over time:
While our previous experience had hard limits on large PRs, this new experience is being built to scale. That said, we’re increasing our limits incrementally. To start with, our additional current limitations are:
How you can help
Thanks for helping us build a better review experience—we read every comment!
Beta Was this translation helpful? Give feedback.
All reactions