Decouple requesting a review from requiring an approval #195867
Replies: 1 comment
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
🏷️ Discussion Type
Product Feedback
Body
Feature
Required reviewer rule
Problem statement
While the feature claims to focus strictly on policy enforcement, it automatically requests reviews from the required teams as soon as a PR is opened. Because all required teams are pinged simultaneously at the very beginning, it is impossible to natively implement N-stage (sequential) PR reviews.
Desired change
Modify the feature to allow strict policy enforcement (requiring the approval to merge) without automatically requesting a review from the required teams when the PR is first opened.
Known workaround
Use workflow actions to validate presence of approvals from members of certain teams and then make those checks required. This however has the downside of validation/enforcement not being protected by platform's RBAC, so in some extreme cases malicious actor can bypass required reviews.
Beta Was this translation helpful? Give feedback.
All reactions