Running ansible with prometheus_install tag fails

[Lukas-Heindl]

I tried running my playbook with ansible-playbook -i production.ini --tags prometheus_install ... and it failed with

TASK [prometheus.prometheus._common : Make sure binary install dir exists] *****
fatal: [prod]: FAILED! => {"msg": "The conditional check 'not __common_binary_install_dir.stat.exists' failed. The error was: error while evaluating conditional (not __common_binary_install_dir.stat.exists): '__common_binary_install_dir' is undefined

The issue seams to be that some tasks like

ansible/roles/_common/tasks/install.yml

Lines 125 to 128 in c7a8953

	- name: "Check existence of binary install dir"
	ansible.builtin.stat:
	path: "{{ _common_binary_install_dir }}"
	register: __common_binary_install_dir

are not tagged with *install like the others.

Is there a specifiy reason for this?

I'm not sure whether this is a mistake or if this is on purpose (the behavior makes me believe it is a mistake but the code looks like it is on purpose).

[Lukas-Heindl]

Also there is

TASK [prometheus.prometheus._common : Create systemd service unit prometheus] ***
An exception occurred during task execution. To see the full traceback, use -vvv. The error was: ansible.errors.AnsibleUndefinedVariable: 'dict object' has no attribute 'packages'

when running as ansible-playbook -i production.ini --tags always,prometheus_configure because ansible.builtin.package is only used in roles/_common/tasks/preflight.yml but

ansible/roles/prometheus/tasks/preflight.yml

Lines 2 to 7 in c7a8953

	- name: Common preflight
	ansible.builtin.include_role:
	name: prometheus.prometheus._common
	tasks_from: preflight.yml
	vars:
	_common_web_listen_address: "{{ prometheus_web_listen_address }}"

is again untagged.

Or am I completely wrong using --tags and the ansible roles for prometheus are only designed to use --skip-tags?

[qhornemangutton]

Hello,

I had the same issue with the task "Create systemd service unit prometheus" when running the playbook with the tag "prometheus_configure". I think a part of the issue comes from the file "prometheus.service.j2" when using "ansible_facts.packages.systemd".

I see two ways to temporarily fix it :

1. Not using tags
2. Add a pre task to gather fact related to package :

  pre_tasks:
    - name: Gather package facts for systemd check
      ansible.builtin.package_facts:
        manager: auto
      tags:
        - always

If you have better options, please tell me

[Lukas-Heindl]

I currently added the untagged tag to my ansible-playbook call, but I don't see this as a permanent fix.

Not quite sure, maybe the tags here are more thought regarding using --skip-tags instead of using --tags but I don't know

[gardar]

I tried running my playbook with ansible-playbook -i production.ini --tags prometheus_install ... and it failed with

TASK [prometheus.prometheus._common : Make sure binary install dir exists] *****
fatal: [prod]: FAILED! => {"msg": "The conditional check 'not __common_binary_install_dir.stat.exists' failed. The error was: error while evaluating conditional (not __common_binary_install_dir.stat.exists): '__common_binary_install_dir' is undefined

The issue seams to be that some tasks like

ansible/roles/_common/tasks/install.yml

Lines 125 to 128 in c7a8953

• name: "Check existence of binary install dir"
  ansible.builtin.stat:
  path: "{{ _common_binary_install_dir }}"
  register: __common_binary_install_dir

are not tagged with *install like the others.

Is there a specifiy reason for this?

I'm not sure whether this is a mistake or if this is on purpose (the behavior makes me believe it is a mistake but the code looks like it is on purpose).

This should be fixed by #669