Skip to content

Memo type inference for federated address #2717

@leofelix077

Description

@leofelix077

Coming from analysis on stellar/freighter-mobile#821, the memo and memo_type returned from federated server are discarded

specified on https://github.com/stellar/stellar-protocol/blob/master/ecosystem/sep-0002.md

The extension has a latent bug: if an exchange federation address returns memo_type: "id" with a numeric memo, the
extension sends it as Memo.text() instead of Memo.id() — which many exchanges reject.

Note on Freighter extension
The browser extension appears to have the same bug. All three federation-resolution call sites only read fedResp.account_id and discard memo / memo_type:

extension/src/popup/components/send/SendTo/hooks/useSendToData.tsx (send flow)
extension/src/popup/helpers/account.ts
extension/src/popup/views/SignTransaction/index.tsx
Worth either fixing there in parallel or filing a GH issue on stellar/freighter so both clients converge on correct SEP-0002 behavior.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions