fix: skip empty benchmarks to avoid infinite loops when CODSPEED_MODE=off#50
Open
OsamaAhmad00 wants to merge 1 commit into
Open
fix: skip empty benchmarks to avoid infinite loops when CODSPEED_MODE=off#50OsamaAhmad00 wants to merge 1 commit into
OsamaAhmad00 wants to merge 1 commit into
Conversation
…=off When `CODSPEED_MODE=off`, empty benchmark bodies (which don't run the `KeepRunning()` loop) fail to advance iteration counts. Instead of triggering a hard `BM_CHECK` failure or stalling in an infinite loop, the runner now intercepts the state and gracefully drops a meaningful error message. References: - Issue: google/benchmark#1962 - Pull Request: google/benchmark#1976
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CODSPEED_MODE=off, empty benchmark bodies (which don't run theKeepRunning()loop) fail to advance iteration counts. Instead of triggering a hardBM_CHECKfailure or stalling in an infinite loop, the runner now intercepts the state and gracefully drops a meaningful error message.References: