Fix forward compatibility for rewritten C##222
Merged
Conversation
Collaborator
I think I like this better. And then add some code comments saying what we can retire if PS starts a new tag series. |
michaelblyons
approved these changes
May 18, 2026
Collaborator
michaelblyons
left a comment
michaelblyons
left a comment
There was a problem hiding this comment.
Works for me. Thanks for the big C# overhaul!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds renamed contexts to maintain compatibility with rewritten C# syntax.
Existing
immediately_popincludes are replaced by explicit patterns to avoid missing context failures.Alternatively a new
immediately-popcontext could be defined and included, which would then override the new one from rewritten C#.caused by sublimehq/Packages#4547