Skip to content

security: stricter pnpm config blockExoticSubdeps & trustPolicy#137

Open
Sheraff wants to merge 1 commit into
TanStack:mainfrom
Sheraff:stricter-pnpm-deps-config
Open

security: stricter pnpm config blockExoticSubdeps & trustPolicy#137
Sheraff wants to merge 1 commit into
TanStack:mainfrom
Sheraff:stricter-pnpm-deps-config

Conversation

@Sheraff
Copy link
Copy Markdown
Contributor

@Sheraff Sheraff commented May 17, 2026

Enables pnpm's no-downgrade trust policy and blocks exotic transitive dependencies via blockExoticSubdeps.

Summary by CodeRabbit

  • Chores
    • Updated workspace configuration settings for enhanced dependency handling and version management policies.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cc462d6c-7ad4-44f2-8842-6e91987ae448

📥 Commits

Reviewing files that changed from the base of the PR and between 8c64c66 and 7617836.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

This PR updates the pnpm workspace configuration to add two security-focused settings: blockExoticSubdeps to block exotic subdependencies and trustPolicy set to 'no-downgrade' to prevent dependency version downgrades.

Changes

Pnpm workspace security configuration

Layer / File(s) Summary
Pnpm security configuration additions
pnpm-workspace.yaml
Adds blockExoticSubdeps: true and trustPolicy: 'no-downgrade' to enable workspace-wide dependency security enforcement.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A workspace now stands guard with care,
Exotic deps blocked through the air,
No downgrades slip, security tight,
Configuration made safe and right!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is minimal and lacks the required template sections including the detailed Changes section, Checklist confirmation, and Release Impact declaration specified in the repository template. Expand the description to follow the template: add a detailed Changes section explaining the motivation, complete the Checklist items, and declare Release Impact (either with a changeset or marking it as dev-only).
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding security-focused pnpm configuration options (blockExoticSubdeps and trustPolicy) to the workspace configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented May 17, 2026

View your CI Pipeline Execution ↗ for commit 7617836

Command Status Duration Result
nx run-many --targets=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2026-05-17 13:59:27 UTC

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 17, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@tanstack/intent@137

commit: 7617836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant