[CI] Build on macos-14 rather than macos-latest#8721
Conversation
33d3989 to
0eb0cf9
Compare
|
It looks like that particular issue does not show up with macOS 14, but I still think we should land this anyway to get us a little closer. |
|
Please update |
Done. I don't suppose there might be reason to prefer the latest macOS/clang for building the release? I guess it would be bad to have them be out-of-sync since we could end up with failures that we don't see until release time. |
|
I'm not aware of benefits of using later OS versions for releases. Usually the opposite is the case I think? But maybe we should test the release builds on latest macos too? That would avoid any surprises here. |
|
I think its probably simplest to just keep them in sync, unless we have good reason to want to build+test twice on macOS. |
|
I am saying we can keep the builds in sync, but add testing of the builds on latest. But maybe that's not worth it. |
| echo "TARBALL=$TARBALL" >> $GITHUB_OUTPUT | ||
| echo "SHASUM=$SHASUM" >> $GITHUB_OUTPUT | ||
| if: ${{ matrix.os == 'macos-latest' || matrix.os == 'windows-11-arm' }} | ||
| if: ${{ matrix.os == 'macos-14' || matrix.os == 'windows-11-arm' }} |
There was a problem hiding this comment.
Actually I think is supposed pick out exactly two specific builds. (i.e. if we have mulitple macos builds we would only want the one to match here).
In emsdk we actually build on macos-13, but sadly there is not macos-13 available in github actions.
In emsdk we actually build on macos-13, but sadly there is not macos-13 available in github actions.
In doing this I'm trying to get binaryen CI to reproduce the current issue we are seeing in emsdk CI:
Split out from #8719