Skip to content

Update .wast tests for async keyword#652

Closed
fitzgen wants to merge 1 commit into
WebAssembly:mainfrom
fitzgen:async-test-updates
Closed

Update .wast tests for async keyword#652
fitzgen wants to merge 1 commit into
WebAssembly:mainfrom
fitzgen:async-test-updates

Conversation

@fitzgen
Copy link
Copy Markdown
Collaborator

@fitzgen fitzgen commented May 16, 2026

No description provided.

@lukewagner
Copy link
Copy Markdown
Member

Does the recent merge of #646 (this commit) subsume this?

@fitzgen
Copy link
Copy Markdown
Collaborator Author

fitzgen commented May 18, 2026

I don't think it fully subsumes this one, as I still get these async keyword errors when updating Wasmtime's git submodule to the latest main:

---- CraneliftNative//home/nick/wasmtime/tests/component-model/test/async/drop-cross-task-borrow.wast ----
failed to run spec test with default engine

Caused by:
    0: failed directive on /home/nick/wasmtime/tests/component-model/test/async/drop-cross-task-borrow.wast:9
    1: failed to parse WebAssembly module
    2: the `async` canonical option requires an async function type (at offset 0xa29)


---- CraneliftPulley//home/nick/wasmtime/tests/component-model/test/async/drop-cross-task-borrow.wast ----
failed to run spec test with default engine

Caused by:
    0: failed directive on /home/nick/wasmtime/tests/component-model/test/async/drop-cross-task-borrow.wast:9
    1: failed to parse WebAssembly module
    2: the `async` canonical option requires an async function type (at offset 0xa29)


---- CraneliftNative/pooling//home/nick/wasmtime/tests/component-model/test/async/drop-cross-task-borrow.wast ----
failed to run spec test with default engine

Caused by:
    0: failed directive on /home/nick/wasmtime/tests/component-model/test/async/drop-cross-task-borrow.wast:9
    1: failed to parse WebAssembly module
    2: the `async` canonical option requires an async function type (at offset 0xa29)

@fitzgen
Copy link
Copy Markdown
Collaborator Author

fitzgen commented May 18, 2026

Will make a new patch on top of main.

@fitzgen fitzgen closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants