chore(e2e): retire vite trusted-publisher override by jacekradko · Pull Request #8526 · clerk/javascript

jacekradko · 2026-05-12T03:54:28Z

Follow-up to #8522. Bumps vite to ^7.3.3 across eight integration test templates and drops the vite@<7.1.3 entry from root pnpm.overrides and TRUSTED_OVERRIDES. vite 7.1.3 is the first version published via OIDC trusted publisher.

Also aligns peer deps for vite 7: bumps @types/node in react-vite to ^22.12.0 (vite 7 declares peerOptional @types/node "^20.19.0 || >=22.12.0", which npm-strict resolution in pkglab rejects under the older ^18.19.33 pin), and @vitejs/plugin-vue in vue-vite to ^6.0.0 (the ^5 line only supports vite 5/6).

@vitejs/plugin-react@^4 already covers vite 4-7 so plugin versions don't need to move. Fixture vite configs are minimal defineConfig({ plugins: [react()] }) and unaffected by 4→7 breaking changes.

Bumps vite direct deps to ^7.3.3 across nine fixture templates and two playground apps that were previously on vite 4/5/6/7.0, then drops the corresponding entry from root pnpm.overrides and TRUSTED_OVERRIDES. vite 7.1.3 is the first version published via OIDC trusted publisher. @vitejs/plugin-react@^4 supports vite 4-7 so plugin versions don't need to move. Fixture vite configs are minimal defineConfig({ plugins: [react()] }) and unaffected by 4→7 breaking changes.

changeset-bot · 2026-05-12T03:54:33Z

🦋 Changeset detected

Latest commit: 7184866

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2026-05-12T03:54:34Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 18, 2026 4:54pm

coderabbitai · 2026-05-12T03:56:59Z

📝 Walkthrough

Walkthrough

This PR removes the global vite override from root pnpm.overrides and from TRUSTED_OVERRIDES, applies a uniform vite devDependency version (^7.3.3) across integration templates (with @types/node and @vitejs/plugin-vue bumps where applicable), and adds a .changeset entry documenting the override retirement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: retiring the vite trusted-publisher override, which aligns with the PR's primary objective of removing the vite@<7.1.3 override entry.
Description check	✅ Passed	The description is directly related to the changeset, providing context about bumping vite versions across templates and removing override entries, which matches the file changes shown in the raw summary.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@integration/templates/vue-vite/package.json`:
- Around line 16-18: The package.json currently pins "@vitejs/plugin-vue":
"^5.1.4" which is incompatible with "vite": "^7.3.3"; update the dependency to a
version that supports Vite 7 (e.g. change "@vitejs/plugin-vue" to "^6.0.0" or
later) so the template can build with Vite 7.3.3 and regenerate/install
lockfiles as needed.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 29470f5d-3bb1-4c7f-ac13-5a8ff967c2f7

📥 Commits

Reviewing files that changed from the base of the PR and between c5fd14c and 4818414.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (13)

.changeset/retire-vite-override.md
integration/constants.ts
integration/templates/chrome-extension-vite/package.json
integration/templates/custom-flows-react-vite/package.json
integration/templates/express-vite/package.json
integration/templates/fastify-vite/package.json
integration/templates/hono-vite/package.json
integration/templates/react-router-library/package.json
integration/templates/react-vite/package.json
integration/templates/vue-vite/package.json
package.json
playground/react-router/package.json
playground/vite-react-ts/package.json

💤 Files with no reviewable changes (1)

integration/constants.ts

pkg-pr-new · 2026-05-12T03:58:27Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8526

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8526

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8526

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8526

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8526

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8526

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8526

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8526

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8526

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8526

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8526

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8526

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8526

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8526

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8526

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8526

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8526

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8526

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8526

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8526

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8526

commit: 7184866

vite 7 declares peerOptional @types/node "^20.19.0 || >=22.12.0", which the react-vite template's ^18.19.33 pin fails under npm's strict resolution (pkglab uses npm internally). Bumps that template's @types/node to ^22.12.0. vue-vite was on @vitejs/plugin-vue ^5.1.4, which only supports vite 5/6. Bumps it to ^6.0.0 for vite 7 support.

# Conflicts: # integration/constants.ts # playground/react-router/package.json # playground/vite-react-ts/package.json # pnpm-lock.yaml

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.changeset/retire-vite-override.md:
- Around line 1-2: The changeset file .changeset/retire-vite-override.md is
empty but should either contain a release entry or be removed; update it to
include the appropriate changeset metadata: add one or more package bump blocks
(package name and bump type: patch/minor/major) plus a short summary describing
"Retire Vite override and standardize template dependency" so the PR produces a
changelog entry, or if this PR truly makes no release changes delete the file to
avoid an empty changeset.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0d2a67b4-5320-4614-bd88-da5024fd6411

📥 Commits

Reviewing files that changed from the base of the PR and between ccb7239 and 7184866.

📒 Files selected for processing (1)

.changeset/retire-vite-override.md

github-actions Bot added playground integration labels May 12, 2026

vercel Bot deployed to Preview May 12, 2026 03:55 View deployment

coderabbitai Bot reviewed May 12, 2026

View reviewed changes

Comment thread integration/templates/vue-vite/package.json Outdated

vercel Bot deployed to Preview May 12, 2026 06:29 View deployment

Merge remote-tracking branch 'origin/main' into jacek/bump-vite

ccb7239

# Conflicts: # integration/constants.ts # playground/react-router/package.json # playground/vite-react-ts/package.json # pnpm-lock.yaml

vercel Bot deployed to Preview May 18, 2026 16:42 View deployment

chore(changeset): drop description from empty changeset

7184866

vercel Bot deployed to Preview May 18, 2026 16:54 View deployment

coderabbitai Bot reviewed May 18, 2026

View reviewed changes

Comment thread .changeset/retire-vite-override.md

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(e2e): retire vite trusted-publisher override#8526

chore(e2e): retire vite trusted-publisher override#8526
jacekradko wants to merge 4 commits into
mainfrom
jacek/bump-vite

jacekradko commented May 12, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented May 12, 2026 •

edited

Loading

Uh oh!

vercel Bot commented May 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented May 12, 2026 •

edited

Loading

Walkthrough

Estimated code review effort

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jacekradko commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

vercel Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkg-pr-new Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jacekradko commented May 12, 2026 •

edited

Loading

changeset-bot Bot commented May 12, 2026 •

edited

Loading

vercel Bot commented May 12, 2026 •

edited

Loading

coderabbitai Bot commented May 12, 2026 •

edited

Loading

pkg-pr-new Bot commented May 12, 2026 •

edited

Loading