chore(upgrade): drop unused execa and temp-dir runtime deps#8579
chore(upgrade): drop unused execa and temp-dir runtime deps#85797188ce06 wants to merge 1 commit into
Conversation
Orphaned by: ff335a0 ("feat(upgrade): Update upgrade CLI structure to support multiple releases (clerk#7385)", Bryce Kalow, 2025-12-08) That commit removed the last source references — both `import { execa } from 'execa'` lines (the refactor moved away from the shell-out pattern entirely) and the `import tempDir from 'temp-dir'` (replaced with native `fs.mkdtempSync(path.join(os.tmpdir(), ...))` in the new test fixture helpers) — but did not update @clerk/upgrade's package.json. The deps have been declared-but-not-imported since 2025-12-08. Customer surface for zero benefit: every install of @clerk/upgrade fetches both from npm, plus the transitive tree under execa (12 unique packages removed from the lockfile by this commit). Verification: - Source grep: $ grep -rE "from\s+['\\"](execa|temp-dir)['\\"]|require\\(['\\"](execa|temp-dir)['\\"]\\)" \\ packages/upgrade --include='*.{ts,tsx,js,jsx,mjs,cjs}' \\ --exclude-dir=node_modules --exclude-dir=dist (no matches) - Lockfile self-consistency: $ pnpm install --frozen-lockfile Done in 10.9s. - Build: $ pnpm turbo run build --filter @clerk/upgrade Tasks: 1 successful, 1 total. - Specific transitive removals (each was reachable only via execa@9.4.1 or temp-dir@3.0.0; other versions of the same package names remain in the lockfile because they're pulled by unrelated deps like cypress, archiver, etc.): @sec-ant/readable-stream@0.4.1 execa@9.4.1 figures@6.1.0 get-stream@9.0.1 human-signals@8.0.1 is-stream@4.0.1 is-unicode-supported@2.1.0 parse-ms@4.0.0 pretty-ms@9.3.0 strip-final-newline@4.0.0 temp-dir@3.0.0 yoctocolors@2.1.2 No source changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Orphaned by: ff335a0
("feat(upgrade): Update upgrade CLI structure to support multiple
releases (#7385)", Bryce Kalow, 2025-12-08)
That commit removed the last source references — both
import { execa } from 'execa'lines (the refactor moved away from the shell-out pattern entirely) and theimport tempDir from 'temp-dir'(replaced with nativefs.mkdtempSync(path.join(os.tmpdir(), ...))in the new test fixture helpers) — but did not update @clerk/upgrade's package.json.The deps have been declared-but-not-imported since 2025-12-08. Customer surface for zero benefit: every install of @clerk/upgrade fetches both from npm, plus the transitive tree under execa (12 unique packages removed from the lockfile by this commit).
Verification:
Source grep: $ grep -rE "from\s+'\"['\"]|require\('\"['\"]\)" \ packages/upgrade --include='*.{ts,tsx,js,jsx,mjs,cjs}' \ --exclude-dir=node_modules --exclude-dir=dist (no matches)
Lockfile self-consistency: $ pnpm install --frozen-lockfile Done in 10.9s.
Build: $ pnpm turbo run build --filter @clerk/upgrade Tasks: 1 successful, 1 total.
Specific transitive removals (each was reachable only via execa@9.4.1 or temp-dir@3.0.0; other versions of the same package names remain in the lockfile because they're pulled by unrelated deps like cypress, archiver, etc.): @sec-ant/readable-stream@0.4.1 execa@9.4.1 figures@6.1.0 get-stream@9.0.1 human-signals@8.0.1 is-stream@4.0.1 is-unicode-supported@2.1.0 parse-ms@4.0.0 pretty-ms@9.3.0 strip-final-newline@4.0.0 temp-dir@3.0.0 yoctocolors@2.1.2
No source changes.