🤖 refactor: reduce generated and media LoC#3306
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
@codex review |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95fef7eb59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Remove bulky checked-in media, replace the transient Lottie loader with a dependency-free logo pulse, and compact generated model/skill artifacts so future generated updates are easier to review. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$17.72`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=17.72 -->
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Reduces repository size by removing bulky checked-in docs media, replacing the transient Lottie loading animation with a dependency-free Mux logo pulse, and compacting generated model/skill artifacts so future generated updates are easier to review.
Background
The workspace goal was to reduce the codebase by 10,000 LoC while improving maintainability, with generated code counting at 1/10th weight and preference for recent-churn hot paths. The audited diff removes 59,586 raw lines and 34,682.1 effective lines after generated-code discounting. Several touched files are active churn points, including
package.json,bun.lock,builtInSkillContent.generated.ts, and UI loading tests.Implementation
code-review.webpscreenshot and deletes the large GIF/MP4 blobs.lottie-reactand the generated dancing-blink JSON payload, replacing the loading indicator with a theme-aware Mux logo pulse that respects reduced motion.models.jsonand built-in skill content remain compact on future refreshes.code-review.webpas the hero refresh path.Validation
bun test src/common/constants/knownModels.test.ts src/common/utils/tokens/modelStats.test.ts src/common/utils/ai/modelCapabilities.test.ts src/node/services/agentSkills/agentSkillsService.test.ts src/node/services/tools/agent_skill_read_file.test.tsbun test src/browser/components/AppLoader/AppLoader.auth.test.tsxbun test src/browser/components/ProjectPage/ProjectPage.autofocus.test.tsx src/browser/components/WorkspaceShell/WorkspaceShell.test.tsx src/browser/components/AppLoader/AppLoader.auth.test.tsx tests/ui/chat/newChatStreamingFlash.test.ts tests/ui/chat/streamInterrupt.test.ts tests/ui/chat/bottomLayoutShift.test.tsbun scripts/gen_builtin_skills.ts checkbun -e 'JSON.parse(await Bun.file("src/common/utils/tokens/models.json").text()); console.log("models.json parses")'make flake-hash-checkmake static-checkRisks
Low product risk. The main user-visible change is that transient loading states now use a simple logo pulse instead of the previous Lottie animation. Docs no longer include the large animated/video hero blobs locally, using an existing static generated screenshot instead.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$17.72