This repository was archived by the owner on Apr 17, 2018. It is now read-only.
removed Gem commands from the bin/dm file.#2
Open
rojotek wants to merge 1 commit into
Open
Conversation
Gem commands to import dm-core and dm-cli are in the gemspec. They shouldn't live in the bin/dm file. (They most certainly shouldn't have the 1.0 versions specified here).
Author
|
Best practices for Gems involve not specifying gem commands inside code: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gem commands to import dm-core and dm-cli are in the gemspec.
They shouldn't live in the bin/dm file.
(They most certainly shouldn't have the 1.0 versions specified here).