Skip to content

Organize Storybook modals and factor shared modal primitives#78

Merged
nedtwigg merged 9 commits into
mainfrom
codex/organize-storybook-modals
May 19, 2026
Merged

Organize Storybook modals and factor shared modal primitives#78
nedtwigg merged 9 commits into
mainfrom
codex/organize-storybook-modals

Conversation

@nedtwigg
Copy link
Copy Markdown
Member

Summary

  • Move the three modal stories into a Modals Storybook category
  • Rename the modal implementations to use Modal consistently across lib and standalone code
  • Add shared modal primitives for frame, review blocks, focus handling, and named stacking layers
  • Reduce duplicated modal surface, header, and clipboard wiring across the three implementations

Testing

  • Built the lib package and standalone app successfully
  • Built Storybook successfully
  • Verified the renamed modal stories in the in-app browser on localhost:6007 with no console errors

nedtwigg and others added 9 commits May 18, 2026 23:34
Strip ModalFrame's unused forwardRef/imperativeHandle, overlayStyle,
zIndex, and trapFocus props; drop the corresponding active flag from
useModalFocusTrap. Remove textarea-only variants from modalReviewBlock
and inline the one textarea callsite. Drop UpdateDebugModal's redundant
open prop (parent already conditionally renders). Inline KillConfirm's
single-callsite content helper and derive the confirm overlay class
from exit inside the modal.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying mouseterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 729f728
Status: ✅  Deploy successful!
Preview URL: https://b34bffdb.mouseterm.pages.dev
Branch Preview URL: https://codex-organize-storybook-mod.mouseterm.pages.dev

View logs

@nedtwigg nedtwigg marked this pull request as ready for review May 19, 2026 08:24
@nedtwigg nedtwigg merged commit bd2e959 into main May 19, 2026
6 checks passed
@nedtwigg nedtwigg deleted the codex/organize-storybook-modals branch May 19, 2026 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant