[Sublist] Fix existing approaches & add new ones#4190
Draft
Yrahcaz7 wants to merge 2 commits into
Draft
Conversation
also move the note about magic values into `introduction.md` and remove unverified statement about performance
Contributor
Author
|
@BethanyG, if I use a slightly modified version of your Sublist solution for a |
Member
If that modification has lead to a whole new approach, I'd just put yourself as the author. I am happy being left off. My name is next to so much stuff, no need to invent more. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes formatting and content of Sublist approaches as outlined here. (Will add at least one additional approach.)
Looking closer at the argument in this PR, I have have to say that I don't fully agree with either side. (Look at the changes in
using-strings/content.mdfor further detail.)