Fixed last_will_test #5 for Actual and Expected#1835
Conversation
|
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
| def test_code_fragments_fit | ||
| # skip | ||
| assert_equal ::EstateExecutor.assemble_code, 1_925_550 | ||
| assert_equal 3253, ::EstateExecutor.assemble_code |
There was a problem hiding this comment.
Definitely is in the right order... expected and actual in that order.
More to "fixup" in the semantics of the test.
Since it is already here, would you like to fix the rest as well?
VaiaPatta1985
left a comment
VaiaPatta1985
left a comment
There was a problem hiding this comment.
This PR changes the expected answer of the last test to an incorrect value, and should not be merged.
3 participants
Discussed in the forums here.