refactor: Avoid redundant lookups in discover.py#406
Open
maayanmatsliah-tech wants to merge 2 commits into
Open
refactor: Avoid redundant lookups in discover.py#406maayanmatsliah-tech wants to merge 2 commits into
maayanmatsliah-tech wants to merge 2 commits into
Conversation
Author
|
Hi! Could a maintainer please add the refactor label? The label check is failing and I don't have permission to add it myself. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This PR simplifies the app name lookup logic in get_app_name() in discover.py.
The previous code built an intermediate set from dir(mod) to check membership before calling getattr. This PR removes the set entirely and uses getattr(mod, name, None) directly, which is both simpler and more idiomatic Python.
No behavior change. Hope this helps! I'm happy to make any changes if necessary.