C++: Add two more fopen-like models.#21862
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds models for the Windows CRT functions _sopen_s and _wsopen_s to the existing Fopen family of modeled functions, so the filename parameter is treated as a buffer read and tainted flow propagates from filename to the output file descriptor parameter.
Changes:
- Extend the
Fopenclass predicate to recognize_sopen_sand_wsopen_s. - Add a
parameterIsReadcase marking parameter index 1 as a buffer for these two functions. - Add a
hasTaintFlowcase routing taint fromisParameterDeref(1)toisParameterDeref(0).
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/lib/semmle/code/cpp/models/implementations/Fopen.qll | Adds _sopen_s / _wsopen_s recognition, buffer-read modeling for the filename parameter, and taint flow to the output fd parameter. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just found two
fopen-like models that we didn't model. See here.