Update Godot.gitignore#4801
Conversation
|
Tiruturififirifufurururufufufufufuuffuf4
sob., 21 lut 2026, 05:06 użytkownik Noah Greer ***@***.***>
napisał:
… Reasons for making this change
As of Godot <https://godotengine.org/> 4.2 the editor has a
Windows-specific workaround for loading extension libraries. Before the
extension library is loaded the Godot editor creates a temp copy of the
extension library .dll file with a ~ prefix (e.g. example.dll =>
~example.dll). When the extension library is unloaded the Godot editor
deletes the temp copy. These copied ~*.dll files are temporary and should
be ignored.
Links to documentation supporting these rule changes
Godot 4.2 changelog
https://godotengine.org/article/godot-4-2-arrives-in-style/#gdextension
Godot PR #80188 GDExtension: Copy DLL to a temp file before opening
godotengine/godot#80188 <godotengine/godot#80188>
Merge and Approval Steps
- Confirm that you've read the contribution guidelines
<https://github.com/github/gitignore/tree/main?tab=readme-ov-file#contributing-guidelines>
and ensured your PR aligns
- Ensure CI is passing
- Get a review and Approval from one of the maintainers
------------------------------
You can view, comment on, or merge this pull request online at:
#4801
Commit Summary
- 8cd0f4e
<8cd0f4e>
Add rule for Godot temp extension library copies on Windows
File Changes
(1 file <https://github.com/github/gitignore/pull/4801/files>)
- *M* Godot.gitignore
<https://github.com/github/gitignore/pull/4801/files#diff-2ebb77c348d86f88a6bf9b0ee2cc88080f53a72ddd7fd1ae52db3372f98b7001>
(3)
Patch Links:
- https://github.com/github/gitignore/pull/4801.patch
- https://github.com/github/gitignore/pull/4801.diff
—
Reply to this email directly, view it on GitHub
<#4801>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BWBQRBLRAA5ZNHJD57YDXU34M7KTPAVCNFSM6AAAAACV3EAOYCVHI2DSMVQWIX3LMV43ASLTON2WKOZTHE3TCMRVGY2TQMA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
Is there anything more I can do to help get this PR ready to be reviewed and merged? I read the contribution guidelines and believe I have followed them correctly. Edit: the PR template was updated remove the bit about ensuring CI is passing, so I updated the description of this PR to match the latest template. |
As of Godot 4.2 the editor has a Windows-specific workaround for loading extension libraries. Before the extension library is loaded the Godot editor creates a temp copy of the extension library `.dll` file with a `~` prefix (e.g. `example.dll` => `~example.dll`). When the extension library is unloaded the Godot editor deletes the temp copy. These copied `~*.dll` files are temporary and should be ignored. References: Godot 4.2 changelog https://godotengine.org/article/godot-4-2-arrives-in-style/#gdextension Godot PR #80188 GDExtension: Copy DLL to a temp file before opening godotengine/godot#80188
NoahGreer
force-pushed
the
update-godot-gitignore-template
branch
from
8cd0f4e to
bf4440e
Compare
NoahGreer
changed the title
|
Hi @dooleydevin, I noticed you had reviewed and merged more recent PRs that were created after this one. Also, I noticed that since I initially opened this PR the pull request template for this repo was updated in #4843, so I revised this PR's description to match the current template. |
|
No worries @NoahGreer 😄 it's just taking us a long time to get in control of this repo's backlog. This looks good to me! |
Thank you! |
3 participants
Link to the application or project's homepage
https://godotengine.org/
Reasons for making this change
As of Godot 4.2 the editor has a Windows-specific workaround for loading extension libraries. Before the extension library is loaded the Godot editor creates a temp copy of the extension library
.dllfile with a~prefix (e.g.example.dll=>~example.dll). When the extension library is unloaded the Godot editor deletes the temp copy. These copied~*.dllfiles are temporary and should be ignored.Links to documentation supporting these rule changes
Godot 4.2 changelog
https://godotengine.org/article/godot-4-2-arrives-in-style/#gdextension
Godot PR #80188 GDExtension: Copy DLL to a temp file before opening
godotengine/godot#80188
Merge and Approval Steps