feat: add self-check tip to check output#2574
Conversation
c6b4bf2 to
5c373b9
Compare
|
Thanks for the work here! We left a suggestion on #2573 — Would you be open to adjusting the PR in that direction? |
5c373b9 to
e886a15
Compare
|
Updated in |
There was a problem hiding this comment.
Pull request overview
Adds a discoverability tip to the specify check command output pointing users to specify self check for CLI version verification, while keeping specify check strictly offline. This also updates docs to clarify the offline vs. version-lookup split and introduces regression tests ensuring no latest-release lookup is triggered by specify check.
Changes:
- Print a
specify self checktip at the end ofspecify checkoutput. - Document the intended separation:
specify check(offline environment scan) vs.specify self check(version lookup). - Add CLI-level tests that assert the tip appears and that latest-release lookup is not invoked.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/__init__.py |
Adds the new self-check tip to the check() command output. |
tests/test_check_tool.py |
Adds CLI invocation tests validating tip presence and enforcing no latest-release lookup. |
docs/reference/core.md |
Clarifies specify check is offline and directs version checks to specify self check. |
docs/upgrade.md |
Adds troubleshooting guidance to run specify self check when behavior suggests an older CLI. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 1
Aligns the new tip with the other `Tip:` lines in `specify check`, which don't end in a period. Per Copilot review feedback on github#2574. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Closes #2573.
Keeps
specify checkas an offline environment scan and adds a discoverability tip for the existingspecify self checkversion lookup.Changes
specify self checktip tospecify checkoutput.specify checknetwork-free; no--latestoption is added.specify checkdoes not call the latest-release lookup.Validation
Local:
uv run pytest tests/test_check_tool.py tests/test_upgrade.py -quvx ruff check src/ tests/test_check_tool.py tests/test_upgrade.pygit diff --check origin/mainuv run specify check --helpCI:
AI Disclosure
Used AI assistance to inspect the existing check/self-check flow, adjust the PR based on review feedback, add tests/docs, and run local validation. The changes were reviewed before submission.