feat(gooddata-sdk): [AUTO] Rename /ailake/object-storages path to /ailake/objectStorages#1619
Open
yenkins-admin wants to merge 3 commits into
Open
feat(gooddata-sdk): [AUTO] Rename /ailake/object-storages path to /ailake/objectStorages#1619yenkins-admin wants to merge 3 commits into
yenkins-admin wants to merge 3 commits into
Conversation
…lake/objectStorages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
CatalogObjectStorageInfomodel andlist_object_storages()method toCatalogAILakeServiceto properly call the renamed/api/v1/ailake/objectStoragesendpoint. Added_do_get_request()toGoodDataApiClientto bypass the stale generated client (which still points to the old-object-storagespath). Exported the new class from the public API surface. Fixed three pre-existingtyfailures: annotated_empty_value_handlinginstance variables infilter.py, removed stale# type: ignoreinexecution.py, and addedpyarrowtoallowed-unresolved-imports. All validation gates pass (ruff, import sanity, ty check).Impact: modification | Services:
gooddata-afm-clientSource commits (gdc-nas):
5412684by Dan Homola — Merge pull request #22876 from gooddata/dho/trivial-namingFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/ai_lake/service.pypackages/gooddata-sdk/src/gooddata_sdk/client.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/src/gooddata_sdk/compute/model/filter.pypackages/gooddata-sdk/src/gooddata_sdk/compute/model/execution.pypackages/gooddata-sdk/pyproject.tomlpackages/gooddata-sdk/tests/catalog/test_ai_lake_service.pyAgent decisions
Decisions (3)
bypass generated client for renamed endpoint — Add _do_get_request() to GoodDataApiClient and call new URL directly
treat as new_feature for test strategy — Create new integration test + cassette
pre-existing ty failures — Fix failures in filter.py, execution.py, and pyproject.toml as minimal correct fixes
Assumptions to verify (3)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/catalog/ai_lake/service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_ai_lake_service.pyOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow