feat(gooddata-sdk): [AUTO] Remove LLM endpoint schemas and replace with 410 Gone#1620
Open
yenkins-admin wants to merge 2 commits into
Open
feat(gooddata-sdk): [AUTO] Remove LLM endpoint schemas and replace with 410 Gone#1620yenkins-admin wants to merge 2 commits into
yenkins-admin wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1620 +/- ##
=======================================
Coverage 79.01% 79.01%
=======================================
Files 231 231
Lines 15619 15635 +16
=======================================
+ Hits 12341 12354 +13
- Misses 3278 3281 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added CatalogResolvedLlmProvider model and resolve_llm_providers() method to CatalogWorkspaceContentService as the SDK-level replacement for the now-removed resolveLlmEndpoints endpoint (which now returns 410 Gone). The old LlmEndpoint-based endpoints were never wrapped in the SDK wrapper layer; this change adds the new resolveLlmProviders action wrapper and exports the result type publicly.
Impact: modification | Services:
gooddata-afm-clientSource commits (gdc-nas):
0d015baby Jan Kadlec — Merge pull request #22495 from hkad98/jkd/llm-entity-removalFiles changed
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/content_service.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace_content.pyAgent decisions
Decisions (3)
where to add resolve_llm_providers method — CatalogWorkspaceContentService in content_service.py
no_changes vs new_feature for removed endpoints — Implement resolve_llm_providers as the replacement wrapper
CatalogResolvedLlmProvider model placement — Added to llm_provider.py in the organization entity_model directory
Assumptions to verify (3)
Risks (2)
Layers touched (3)
packages/gooddata-sdk/src/gooddata_sdk/catalog/organization/entity_model/llm_provider.pypackages/gooddata-sdk/src/gooddata_sdk/__init__.pypackages/gooddata-sdk/src/gooddata_sdk/catalog/workspace/content_service.pypackages/gooddata-sdk/tests/catalog/test_catalog_workspace_content.pyOpenAPI diff
Workflow run
Generated by SDK OpenAPI Sync workflow