Tswast magics blog#17216
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Jupyter notebook tutorial demonstrating how to query local Excel files using BigQuery DataFrames. The reviewer identified several critical issues: the notebook contains significant redundancy and redundant implementation drafts that should be refactored into a single linear tutorial. Furthermore, there is a functional error where the %%bqsql magic fails because the extension is not loaded in a code cell, and a hardcoded project ID needs to be replaced with a placeholder for user accessibility.
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", |
There was a problem hiding this comment.
The notebook contains significant redundancy and appears to be a combination of multiple drafts. Cells 2-9 perform data acquisition and preparation, Cell 10 contains a full tutorial in markdown text, and then Cells 11-14 repeat the data acquisition steps using different methods (e.g., wget instead of requests). The notebook should be refactored into a single, linear tutorial to improve maintainability and user experience.
| } | ||
| ], | ||
| "source": [ | ||
| "%%bqsql df_with_year\n", |
There was a problem hiding this comment.
The %%bqsql magic will fail because the bigframes extension has not been loaded in a code cell. The UsageError in the cell output at line 1684 confirms this. You must include a code cell with %load_ext bigframes before using the magic.
| "# TODO(developer): Follow the instructions at\n", | ||
| "# https://docs.cloud.google.com/bigquery/docs/sandbox and set the project to the\n", | ||
| "# ID of the project you created.\n", | ||
| "bpd.options.bigquery.project = \"swena-bq-sandbox\"" |
There was a problem hiding this comment.
The project ID is hardcoded to swena-bq-sandbox. This should be replaced with a placeholder like your-project-id to ensure that users are prompted to provide their own project ID, as indicated in the preceding comment and the tutorial text.
bpd.options.bigquery.project = "your-project-id"
1 participant
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕