Skip to content

refactor(langchain): clean redundancy ifelse.#37448

Open
湛露先生 (zhanluxianshen) wants to merge 1 commit into
langchain-ai:masterfrom
zhanluxianshen:redundancy-ifelse
Open

refactor(langchain): clean redundancy ifelse.#37448
湛露先生 (zhanluxianshen) wants to merge 1 commit into
langchain-ai:masterfrom
zhanluxianshen:redundancy-ifelse

Conversation

@zhanluxianshen
Copy link
Copy Markdown
Contributor

Fixes #


Read the full contributing guidelines: https://docs.langchain.com/oss/python/contributing/overview

All contributions must be in English. See the language policy.

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

Thank you for contributing to LangChain! Follow these steps to have your pull request considered as ready for review.

  1. PR title: Should follow the format: TYPE(SCOPE): DESCRIPTION
  1. PR description:
  • Write 1-2 sentences summarizing the change.
  • The Fixes #xx line at the top is required for external contributions — update the issue number and keep the keyword. This links your PR to the approved issue and auto-closes it on merge.
  • If there are any breaking changes, please clearly describe them.
  • If this PR depends on another PR being merged first, please include "Depends on #PR_NUMBER" in the description.
  1. Run make format, make lint and make test from the root of the package(s) you've modified.
  • We will not consider a PR unless these three are passing in CI.
  1. How did you verify your code works?

Additional guidelines:

  • All external PRs must link to an issue or discussion where a solution has been approved by a maintainer, and you must be assigned to that issue. PRs without prior approval will be closed.
  • PRs should not touch more than one package unless absolutely necessary.
  • Do not update the uv.lock files or add dependencies to pyproject.toml files (even optional ones) unless you have explicit permission to do so by a maintainer.

Social handles (optional)

Twitter: @
LinkedIn: https://linkedin.com/in/

@github-actions github-actions Bot added langchain `langchain` package issues & PRs size: XS < 50 LOC labels May 15, 2026
@langchain-automated-triage langchain-automated-triage Bot added trusted-contributor >= 5 merged PRs in the `langchain-ai/langchain` repo external labels May 15, 2026
@zhanluxianshen 湛露先生 (zhanluxianshen) changed the title clean redundancy ifelse. fix(langchain/agents‎): clean redundancy ifelse. May 15, 2026
@github-actions github-actions Bot added the fix For PRs that implement a fix label May 15, 2026
@zhanluxianshen 湛露先生 (zhanluxianshen) changed the title fix(langchain/agents‎): clean redundancy ifelse. refactor(langchain/agents‎): clean redundancy ifelse. May 15, 2026
@github-actions github-actions Bot added refactor PRs that include a refactor and removed fix For PRs that implement a fix labels May 15, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will not alter performance

✅ 2 untouched benchmarks
⏩ 13 skipped benchmarks1


Comparing zhanluxianshen:redundancy-ifelse (22f482b) with master (f42d80c)2

Open in CodSpeed

Footnotes

  1. 13 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on master (0831e44) during the generation of this report, so f42d80c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@zhanluxianshen 湛露先生 (zhanluxianshen) changed the title refactor(langchain/agents‎): clean redundancy ifelse. refactor(langchain): clean redundancy ifelse. May 15, 2026
Signed-off-by: zhanluxianshen <yanggangtony@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external langchain `langchain` package issues & PRs refactor PRs that include a refactor size: XS < 50 LOC trusted-contributor >= 5 merged PRs in the `langchain-ai/langchain` repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant