fix(kf6-karchive) remove password protected files from source tarball#17295
Open
anphel31 wants to merge 1 commit into
Open
fix(kf6-karchive) remove password protected files from source tarball#17295anphel31 wants to merge 1 commit into
anphel31 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the kf6-karchive component to use a deterministically repacked upstream karchive-6.23.0.tar.xz with a password-protected test fixture removed, allowing the SRPM to pass the AZL RPM-signing (ESRP) scanning pipeline while keeping the produced RPMs functionally unchanged.
Changes:
- Add a
kf6-karchivededicated component definition that replaces upstreamSource0with a modified tarball hosted in the lookaside underpkgs_modified/. - Add a deterministic
modify_source.shhelper script to stripautotests/data/password_protected.7zand repack byte-identically. - Regenerate rendered outputs (
sources,.spec) and refresh the component lock fingerprint.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/kf6-karchive/modify_source.sh |
New deterministic strip-and-repack helper to remove the password-protected fixture and produce a reproducible tarball + SHA512. |
base/comps/kf6-karchive/kf6-karchive.comp.toml |
Defines a source-files replacement for upstream karchive-6.23.0.tar.xz pointing at the repacked lookaside blob with justification. |
base/comps/components.toml |
Removes the inline kf6-karchive entry and leaves a pointer to the new dedicated component file. |
specs/k/kf6-karchive/sources |
Updates Source0 SHA512 to match the repacked tarball. |
specs/k/kf6-karchive/kf6-karchive.spec |
Regenerated rendered spec with an rpmautospec Release bump only. |
locks/kf6-karchive.lock |
Updates the component input fingerprint after the component definition change. |
christopherco
approved these changes
May 16, 2026
christopherco
requested changes
May 16, 2026
f803ed0 to
74049ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: AB#19875
Summary
Strip
autotests/data/password_protected.7zfrom the upstreamkarchive-6.23.0.tar.xzso the SRPM can clear the AZL RPM-signing pipeline (ESRP), which rejects
encrypted/unscannable payloads.
Why
The upstream KDE tarball ships a deliberately password-protected 7-Zip archive
as a fixture for the karchive autotests. ESRP cannot scan it and refuses to
sign the SRPM.
The autotests are not built or run in our spec:
%checkblock.BUILD_TESTING=ON, which we don't set.%filesdoes not referenceautotests/, so it never ships in any binary RPM.Stripping the fixture is functionally inert; the published RPMs are unchanged.
Mechanism
Same
replace-upstreampattern used forfirefox,yara, andexfatprogs:base/comps/kf6-karchive/modify_source.sh— deterministic strip-and-repackhelper. Downloads upstream, verifies its SHA-512, removes the fixture, and
repacks with
LC_ALL=C tar --sort=name --owner=0 --group=0 --numeric-owner --mtime=@1577836800 --format=gnu | xz -T 1 -9. Re-running yields abyte-identical tarball (verified across two local runs). Output lives at
base/build/work/scratch/kf6-karchive/(covered by the top-level.gitignoreviabuild/). Prints a ready-to-pasteaz storage blob uploadcommand.
base/comps/kf6-karchive/kf6-karchive.comp.toml— new dedicated comp fileadding a
[[components.kf6-karchive.source-files]]entry that points at therepacked tarball in the lookaside
repocontainer underpkgs_modified/.Uses
replace-upstream = true+replace-reason = "..."to swap thesame-named upstream entry in the Fedora
sourcesmanifest in place — nospec edit, no
file-removeoverlay needed.base/comps/components.toml— inline[components.kf6-karchive]replacedwith a comment pointer to the new dedicated file (matches the convention
used for firefox/yara/exfatprogs).
specs/k/kf6-karchive/sources— regenerated. Source0 SHA-512 now points atthe repacked tarball; the
karchive-6.23.0.tar.xz.sigline is leftuntouched (the spec doesn't gpgverify it, and a stale
.sigis harmless;replacing it would also be wrong since we no longer match the upstream
tarball it signed).
specs/k/kf6-karchive/kf6-karchive.spec— regenerated; rpmautospec advancesthe release counter (no functional change).
locks/kf6-karchive.lock— refreshed viaazldev comp update.Modified-tarball SHA-512
882c5890bca4dd75f82ef377ae05f1a5bb6b301b9aee9952b6875b8333307f7de04979b85a787e4e7e48b9227282fb952f9d436163778c5b5c2cd3e02247d8fe
Reproducible by anyone with the same upstream input — re-run
bash base/comps/kf6-karchive/modify_source.shto verify.Validation
STATUS: ok).origin.urireferences.