test: make Brotli 16GB test wait for backpressure#63389
Open
trivikr wants to merge 1 commit into
Open
Conversation
Wait for the Brotli decoder to fill its readable buffer before checking that decompression stops at the high water mark. This avoids racing the fixed timeout against libuv worker-pool scheduling. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
nodejs-github-bot
added
needs-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63389 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.01%
==========================================
Files 714 714
Lines 225629 225648 +19
Branches 42702 42694 -8
==========================================
+ Hits 203211 203218 +7
+ Misses 14232 14218 -14
- Partials 8186 8212 +26 🚀 New features to boost your workflow:
|
aduh95
reviewed
May 18, 2026
Comment on lines
+20
to
+23
| const timeout = setTimeout(() => { | ||
| assert.fail(`Timed out waiting for Brotli output. ` + | ||
| `Buffered ${decoder._readableState.buffer.length} chunks.`); | ||
| }, common.platformTimeout(5000)); |
Contributor
There was a problem hiding this comment.
Suggested change
| const timeout = setTimeout(() => { | |
| assert.fail(`Timed out waiting for Brotli output. ` + | |
| `Buffered ${decoder._readableState.buffer.length} chunks.`); | |
| }, common.platformTimeout(5000)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
parallel/test-zlib-brotli-16GBto wait until the Brotlidecoder reaches the expected readable-buffer backpressure point
before asserting the buffered chunk count.
The previous test used a fixed timeout and could check
_readableState.buffer.lengthbefore libuv worker-pool processing had pushed any output, causing intermittent
failures like
0 !== 4on loaded CI machines.Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure
Assisted-by: openai:gpt-5.5