Skip to content

test: avoid test_runner watch restart in spec snapshot#63392

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:flaky-test-output-test-runner-watch-spec
Open

test: avoid test_runner watch restart in spec snapshot#63392
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:flaky-test-output-test-runner-watch-spec

Conversation

@trivikr
Copy link
Copy Markdown
Member

@trivikr trivikr commented May 17, 2026

This updates the test_runner watch-mode spec reporter fixture to pass
explicit test files to run().

The fixture no longer watches the whole temporary directory, so setup writes
cannot race with watcher initialization and emit an unexpected restart banner.

Refs:


Assisted-by: openai:gpt-5.5

Pass explicit test files to the watch-mode spec reporter fixture.
This prevents setup writes from triggering a watch restart.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Assisted-by: openai:gpt-5.5
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (bc90667) to head (d501a41).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63392   +/-   ##
=======================================
  Coverage   90.05%   90.06%           
=======================================
  Files         714      714           
  Lines      225656   225656           
  Branches    42696    42701    +5     
=======================================
+ Hits       203214   203227   +13     
+ Misses      14220    14216    -4     
+ Partials     8222     8213    -9     

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2026
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@trivikr trivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants