Support for new preview encoding schema#115
Merged
Merged
Conversation
Signed-off-by: dkiselev <dmitry.v.kiselev@gmail.com>
Deploying gtfs-osm-matcher with
|
| Latest commit: |
a1a16d1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1d69818f.gtfs-osm-matcher.pages.dev |
| Branch Preview URL: | https://new-encoding.gtfs-osm-matcher.pages.dev |
Signed-off-by: dkiselev <dmitry.v.kiselev@gmail.com>
Signed-off-by: dkiselev <dmitry.v.kiselev@gmail.com>
Signed-off-by: dkiselev <dmitry.v.kiselev@gmail.com>
kiselev-dv
force-pushed
the
new-encoding
branch
from
d7b5cff to
d3c7f91
Compare
If only next 5 arrivals is displayed, some routes were appear with empty timetable. Do not display them. Signed-off-by: dkiselev <dmitry.v.kiselev@gmail.com>
biodranik
reviewed
Mar 22, 2026
Member
biodranik
left a comment
biodranik
left a comment
There was a problem hiding this comment.
Code review — correctness, quality, and efficiency suggestions.
| const regionStops = schedulesPerRegion.map(schedule => { | ||
|
|
||
| const sections = (filteredByPeriod.length > 0 ? filteredByPeriod : s.sections).filter(section => matchDate(section, i_date, dow)); | ||
| schedule.sort(stopPlatformCodeCmp); |
Member
There was a problem hiding this comment.
Perf: sorting on every render. schedule.sort() mutates the memo'd array and runs on every render (outside useMemo). Same for routes.sort() at line 109. Consider wrapping regionStops in its own useMemo, or moving the sort+filter+map logic into the existing schedulesPerRegion memo.
Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Signed-off-by: Dmitry Kiselev <dmitry.v.kiselev@gmail.com>
Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Signed-off-by: Dmitry Kiselev <dmitry.v.kiselev@gmail.com>
Co-authored-by: Alexander Borsuk <170263+biodranik@users.noreply.github.com> Signed-off-by: Dmitry Kiselev <dmitry.v.kiselev@gmail.com>
Signed-off-by: dkiselev <dmitry.v.kiselev@gmail.com>
Signed-off-by: dkiselev <dmitry.v.kiselev@gmail.com>
Signed-off-by: dkiselev <dmitry.v.kiselev@gmail.com>
Signed-off-by: dkiselev <dmitry.v.kiselev@gmail.com>
Signed-off-by: dkiselev <dmitry.v.kiselev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.