Fix GH-22023 crash during ZTS thread startup#22027
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-22023 by initializing
last_fatal_error_backtraceinexecutor_globals_ctor().On Apache + ZTS,
zend_new_thread_end_handler()may refresh INI caches beforeinit_executor()runs for the new thread. Ifsession.use_trans_sid=1triggers its startup deprecation in that window,zend_error_zstr_at()can destroyEG(last_fatal_error_backtrace)before it has been initialized, causing an access violation and Apache child restart.This change makes the per-thread executor globals safe for that early warning path.