Fix GH-22062: SplDoublyLinkedList iterator UAF via destructor releasi…#22066
Closed
devnexen wants to merge 1 commit into
Closed
Fix GH-22062: SplDoublyLinkedList iterator UAF via destructor releasi…#22066devnexen wants to merge 1 commit into
devnexen wants to merge 1 commit into
Conversation
…asing next node. Pin the new traverse target via SPL_LLIST_CHECK_ADDREF before the shift/pop destructor runs. Otherwise a destructor that unlinks the next node (e.g. offsetUnset) frees it, leaving the iterator with a dangling pointer.
Girgias
approved these changes
May 18, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Probably should be backported?
Member
Author
|
right I was not sure @iluuu1994 would agree due to the nature of the bug report (super crafted code). but I always can. |
Member
|
Indeed, imo such changes should go to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ng next node.
Pin the new traverse target via SPL_LLIST_CHECK_ADDREF before the shift/pop destructor runs. Otherwise a destructor that unlinks the next node (e.g. offsetUnset) frees it, leaving the iterator with a dangling pointer.