ext/intl: various optimization#22069
Draft
LamentXU123 wants to merge 3 commits into
Draft
Conversation
Member
|
If you have further optimisations plan you can put it there too. |
LamentXU123
changed the title
array_init_size instead of array_init when the size is known
LamentXU123
force-pushed
the
opt-intl
branch
3 times, most recently
from
0018bf2 to
da1313e
Compare
devnexen
reviewed
May 17, 2026
| } | ||
| if (date_type == UDAT_PATTERN && time_type != UDAT_PATTERN) { | ||
| intl_error_set(NULL, U_ILLEGAL_ARGUMENT_ERROR, "datefmt_create: time format must be UDAT_PATTERN if date format is UDAT_PATTERN", 0); | ||
| intl_error_set(NULL, U_ILLEGAL_ARGUMENT_ERROR, "datefmt_create: time format must be IntlDateFormatter::PATTERN if date format is IntlDateFormatter::PATTERN", 0); |
Member
There was a problem hiding this comment.
optimisations need to land in master, this is not one.
Contributor
Author
There was a problem hiding this comment.
Let's open a separate PR for this :)
Contributor
Author
There was a problem hiding this comment.
I add this to #22073 targeting PHP 8.4 now this is targeting master.
Also lots of work remains here so feel free to unsubscribe. I will request for your review after everything is done :) p.s. could you delete those tags for me (just leave the ext:intl is fine)? there appears to be some github glitch...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
errorsarray with the correct size infill_errors()#21560 and ext/openssl: various arrays optimisations. #18377uenum_count(), reset it, and switchedtransliterator_list_ids()toarray_init_size(). So we now use ICU APIs to get total length and use array_init_size instead of array_init directly here.