ext/session: reject null bytes in session.cookie_path, session.cookie_domain, session.cache_limiter#22074
Open
jorgsowa wants to merge 1 commit into
Open
ext/session: reject null bytes in session.cookie_path, session.cookie_domain, session.cache_limiter#22074jorgsowa wants to merge 1 commit into
jorgsowa wants to merge 1 commit into
Conversation
…_domain, session.cache_limiter
|
The fix looks correct and the test coverage is solid. One small question: the UPGRADING notes mention that session_module_name() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject null bytes in
session.cookie_path,session.cookie_domain,session.cache_limiter.cookie_path/cookie_domain: When the session cookie was sent,php_session_send_cookie()built the Set-Cookie header including the raw null byte. The SAPI layer (sapi_header_op) emitted a genericE_WARNING: Header may not contain NUL bytesand returned FAILURE, butphp_session_send_cookie()did not check that return value and returned SUCCESS — so the session cookie was silently dropped whilesession_start()still returned true.cache_limiter: The limiter name is looked up viastrcasecmp(lim->name, ZSTR_VAL(PS(cache_limiter))), which stops at the null byte, so "nocache\0evil" would silently behave as "nocache". The null byte was effectively ignored but still accepted without complaint.