Skip to content

ext/intl: Fix argument position for uninitialized calendar arguments #22079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LamentXU123 wants to merge 1 commit into
base: PHP-8.4
Choose a base branch
from
+42 −3
Open

ext/intl: Fix argument position for uninitialized calendar arguments #22079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ PHP NEWS
. Fix incorrect argument positions in out-of-bounds errors for
IntlCalendar::set(), IntlCalendar::setDate(), IntlCalendar::setDateTime(),
and IntlGregorianCalendar date/time construction. (Weilin Du)
. Fix incorrect argument positions for uninitialized calendar arguments in
IntlCalendar::equals(), ::before(), ::after(), and ::isEquivalentTo().
(Weilin Du)
. Expose Spoofchecker restriction-level APIs on all supported ICU
versions. (Weilin Du)
. Fix SpoofChecker::setAllowedChars() to report PHP constant names
Expand Down
6 changes: 3 additions & 3 deletions ext/intl/calendar/calendar_methods.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ static void _php_intlcal_before_after(

when_co = Z_INTL_CALENDAR_P(when_object);
if (when_co->ucal == NULL) {
zend_argument_error(NULL, 2, "is uninitialized");
zend_argument_error(NULL, hasThis() ? 1 : 2, "is uninitialized");
RETURN_THROWS();
}

Expand Down Expand Up @@ -774,7 +774,7 @@ U_CFUNC PHP_FUNCTION(intlcal_is_equivalent_to)

other_co = Z_INTL_CALENDAR_P(other_object);
if (other_co->ucal == NULL) {
zend_argument_error(NULL, 2, "is uninitialized");
zend_argument_error(NULL, hasThis() ? 1 : 2, "is uninitialized");
RETURN_THROWS();
}

Expand Down Expand Up @@ -912,7 +912,7 @@ U_CFUNC PHP_FUNCTION(intlcal_equals)
CALENDAR_METHOD_FETCH_OBJECT;
other_co = Z_INTL_CALENDAR_P(other_object);
if (other_co->ucal == NULL) {
zend_argument_error(NULL, 2, "is uninitialized");
zend_argument_error(NULL, hasThis() ? 1 : 2, "is uninitialized");
RETURN_THROWS();
}

Expand Down
36 changes: 36 additions & 0 deletions ext/intl/tests/calendar_uninitialized_argument_position.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
--TEST--
IntlCalendar methods report the correct argument position for uninitialized calendar arguments
--EXTENSIONS--
intl
--FILE--
<?php

$calendar = IntlGregorianCalendar::createFromDate(2024, 0, 1);
$uninitialized = (new ReflectionClass(IntlGregorianCalendar::class))->newInstanceWithoutConstructor();

foreach (['equals', 'before', 'after', 'isEquivalentTo'] as $method) {
try {
$calendar->$method($uninitialized);
} catch (Error $e) {
echo $method, ': ', $e->getMessage(), PHP_EOL;
}
}

foreach (['intlcal_equals', 'intlcal_before', 'intlcal_after', 'intlcal_is_equivalent_to'] as $function) {
try {
$function($calendar, $uninitialized);
} catch (Error $e) {
echo $function, ': ', $e->getMessage(), PHP_EOL;
}
}

?>
--EXPECT--
equals: IntlCalendar::equals(): Argument #1 ($other) is uninitialized
before: IntlCalendar::before(): Argument #1 ($other) is uninitialized
after: IntlCalendar::after(): Argument #1 ($other) is uninitialized
isEquivalentTo: IntlCalendar::isEquivalentTo(): Argument #1 ($other) is uninitialized
intlcal_equals: intlcal_equals(): Argument #2 ($other) is uninitialized
intlcal_before: intlcal_before(): Argument #2 ($other) is uninitialized
intlcal_after: intlcal_after(): Argument #2 ($other) is uninitialized
intlcal_is_equivalent_to: intlcal_is_equivalent_to(): Argument #2 ($other) is uninitialized
Loading