Use idiomatic Effect decoding for VCS config#2740
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
.t3code/vcs.jsonwithSchema.fromJsonString/Schema.decodeUnknownOptioninstead of manualJSON.parseplus a schema guard.Optioninternally for missing VCS config paths and unreadable config contents.Duration.seconds(15)instead of a millisecond constant.Why
These are small Effect idiom improvements that keep config parsing schema-driven, make absent values explicit, and avoid raw duration numbers in cache policy code.
UI Changes
None.
Checklist
Note
Use idiomatic Effect
Optiondecoding for VCS project configJSON.parse+ try/catch in VcsProjectConfig.ts with Effect'sSchema.fromJsonStringandSchema.decodeUnknownOption, returningOptiontypes throughout.findConfigPathandreadConfiguredKindnow returnOption<string>and log a warning on read failure instead of returningnull..t3code/vcs.json, assertingresolveKindfalls back to'auto'.WORKSPACE_CACHE_TTL_MSnumber constant withDuration.seconds(15)in WorkspaceEntries.ts.Macroscope summarized 0593260.