Skip to content

Add provider profiles to settings#2746

Closed
jamesx0416 wants to merge 5 commits into
pingdotgg:mainfrom
jamesx0416:main
Closed

Add provider profiles to settings#2746
jamesx0416 wants to merge 5 commits into
pingdotgg:mainfrom
jamesx0416:main

Conversation

@jamesx0416
Copy link
Copy Markdown
Contributor

@jamesx0416 jamesx0416 commented May 18, 2026

What Changed

  • Adds a Profiles section to Settings > General for enabled provider instances.
  • Lets users select, add, configure, and delete provider profiles backed by providerInstances.
  • Passes Codex profile and launch args through app-server, session runtime, and codex exec paths.
  • Resolves Codex profile model providers so custom providers like codex-lb do not incorrectly require codex login.

Why

Provider settings need named per-provider presets without changing active sessions. Reusing providerInstances keeps the behavior aligned with existing provider architecture, while sticky composer selection makes profile changes apply to future composer selections.

The Codex status/runtime fixes make profile-specific settings actually affect launched sessions and status/model discovery.

UI Changes

Settings > General now shows a Profiles section above General. Each enabled provider appears as a row with a profile selector, Add profile action, collapsible profile settings, and delete action for custom profiles.

Screenshots/video not attached yet because this is a draft PR.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Add provider profiles to Codex settings with sticky composer profile selection

  • Adds profileName and launchArgs fields to CodexSettings and CodexSettingsPatch in settings.ts, allowing users to configure named Codex profiles and extra CLI arguments.
  • Settings UI gains a new Profiles section in SettingsPanels.tsx where users can add, edit, delete, and switch between provider profiles per driver.
  • Codex CLI invocations (text generation, session runtime, app-server probe) now prepend -p <profileName> and extra launchArgs before subcommands via a shared buildCodexGlobalArgs helper in CodexCliArgs.ts.
  • Thread start requests now include a modelProvider resolved from the active Codex profile via readCodexProfileModelProvider, and the app-server probe derives requiresOpenaiAuth from profile config when available.
  • Switching profiles in settings calls setStickyModelSelectionForInstances in composerDraftStore.ts, rebinding existing drafts that target the affected provider instances to the newly selected profile.
  • Behavioral Change: snapshot.account.requiresOpenaiAuth returned by checkCodexProviderStatus may now differ from prior behavior when a Codex profile overrides the model provider.

Macroscope summarized 868f998.

Add provider profile controls to the General settings panel and extend the Codex settings schema to store profile names and extra CLI args. This keeps the UI and config round-trippable so profile choices can be edited, validated, and exercised in tests.
Thread Codex profileName and launchArgs through provider probing, session startup, and text generation so the runtime uses one shared CLI-args builder. This keeps the app-server launch path and git text generation aligned with the new Codex settings fields.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 2c8464d8-7f91-48b6-8319-6928bf033411

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels May 18, 2026
@jamesx0416 jamesx0416 closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant