Add provider profiles to settings#2746
Closed
jamesx0416 wants to merge 5 commits into
Closed
Conversation
Add provider profile controls to the General settings panel and extend the Codex settings schema to store profile names and extra CLI args. This keeps the UI and config round-trippable so profile choices can be edited, validated, and exercised in tests.
Thread Codex profileName and launchArgs through provider probing, session startup, and text generation so the runtime uses one shared CLI-args builder. This keeps the app-server launch path and git text generation aligned with the new Codex settings fields.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
Provider settings need named per-provider presets without changing active sessions. Reusing providerInstances keeps the behavior aligned with existing provider architecture, while sticky composer selection makes profile changes apply to future composer selections.
The Codex status/runtime fixes make profile-specific settings actually affect launched sessions and status/model discovery.
UI Changes
Settings > General now shows a Profiles section above General. Each enabled provider appears as a row with a profile selector, Add profile action, collapsible profile settings, and delete action for custom profiles.
Screenshots/video not attached yet because this is a draft PR.
Checklist
Note
Add provider profiles to Codex settings with sticky composer profile selection
profileNameandlaunchArgsfields toCodexSettingsandCodexSettingsPatchin settings.ts, allowing users to configure named Codex profiles and extra CLI arguments.-p <profileName>and extralaunchArgsbefore subcommands via a sharedbuildCodexGlobalArgshelper in CodexCliArgs.ts.modelProviderresolved from the active Codex profile viareadCodexProfileModelProvider, and the app-server probe derivesrequiresOpenaiAuthfrom profile config when available.setStickyModelSelectionForInstancesin composerDraftStore.ts, rebinding existing drafts that target the affected provider instances to the newly selected profile.snapshot.account.requiresOpenaiAuthreturned bycheckCodexProviderStatusmay now differ from prior behavior when a Codex profile overrides the model provider.Macroscope summarized 868f998.