refactor: deprecate pytz in favor of builtin zoneinfo#2757
Conversation
351a3d7 to
812539d
Compare
|
@JoLo90 thanks for taking this on. Am I correct in thinking that, other that removing Since the intent is to remove |
|
@cwhanse |
7793ea6 to
2c4be54
Compare
cwhanse
left a comment
There was a problem hiding this comment.
Two other items:
- Thanks for showing how to fix the CI issues with Windows tests. But let's not do that fix in this PR; should be it's own PR. Please revert changes to pytest.yml
- There are two Warnings in the iPython notebook with a local path. It would help if those messages were suppressed somehow. Also, can you rerun the notebook with the execution counter reset?
|
|
||
| The read-only ``pytz`` attribute will stay in sync with any changes made | ||
| using ``tz``. | ||
| The ``pytz`` attribute is deprecated. Use ``tz`` property instead. |
There was a problem hiding this comment.
| The ``pytz`` attribute is deprecated. Use ``tz`` property instead. | |
| The ``pytz`` attribute is deprecated. Use ``tz`` instead. |
|
|
||
| Deprecations | ||
| ~~~~~~~~~~~~ | ||
| * Deprecated ``Location.pytz`` attribute. Use ``Location.tz`` property instead. |
There was a problem hiding this comment.
| * Deprecated ``Location.pytz`` attribute. Use ``Location.tz`` property instead. | |
| * ``Location.pytz`` is deprecated. Use ``Location.tz`` instead. |
2c4be54 to
5e45255
Compare
|
@cwhanse I implemented your comments and remove the local path warning in the jupyter notebook (note that these local paths appear in the other notebooks). The CI issues with Windows seem to be solved, so I won't open a new PR. |
5e45255 to
ff907e1
Compare
Description
Replaces pytz with Python's built-in zoneinfo module for all timezone handling in pvlib.
There is an ongoing issue with micromamba that has been solved thanks to mamba-org/setup-micromamba#306. See commit [ci: update micromamba setup and version].
Changes
Checklist
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.