Skip to content

CI: Move Homebrew dependencies into Brewfile #148335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 10 commits into from
May 15, 2026
Merged

CI: Move Homebrew dependencies into Brewfile #148335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2b36429
Move Homebrew dependencies into Brewfile
hugovk Apr 7, 2026
301147e
No need to link the default version
hugovk Apr 10, 2026
f54be75
Explicitly install tcl-tk9
hugovk Apr 10, 2026
f8abb34
@
hugovk Apr 10, 2026
c37c6da
Merge remote-tracking branch 'upstream/main' into 3.15-brewfile
hugovk Apr 12, 2026
3a804b8
Only install gmake from Homebrew on CI
hugovk Apr 12, 2026
b29865e
Add mpdecimal and zstd to Brewfile
hugovk Apr 12, 2026
886e8b7
Move to Misc/Brewfile
hugovk Apr 20, 2026
673a922
Include Linux deps
hugovk May 1, 2026
270931e
Merge branch 'main' into 3.15-brewfile
hugovk May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/reusable-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@ jobs:
run: echo "IMAGE_OS_VERSION=${ImageOS}-${ImageVersion}" >> "$GITHUB_ENV"
- name: Install Homebrew dependencies
run: |
brew install pkg-config openssl@3.5 xz gdbm tcl-tk@9 make
# Because alternate versions are not symlinked into place by default:
brew link --overwrite tcl-tk@9
Copy link
Copy Markdown
Member Author

@hugovk hugovk Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will backport to 3.10, but we still need to link tcl-tk@8 there. And put tcl-tk@8 in the Brewfile.

brew bundle --file=Misc/Brewfile
brew install make
- name: Configure CPython
run: |
MACOSX_DEPLOYMENT_TARGET=10.15 \
Expand Down
15 changes: 15 additions & 0 deletions Misc/Brewfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
brew "gdbm"
brew "mpdecimal"
brew "openssl@3.5"
brew "pkg-config"
brew "tcl-tk@9"
brew "xz"
Comment thread
hugovk marked this conversation as resolved.
brew "zstd"
Comment thread
hugovk marked this conversation as resolved.

brew "bzip2" if OS.linux?
brew "expat" if OS.linux?
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland May 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why expat, since we bundle it, should it also not be an option?

Copy link
Copy Markdown
Member

@brettcannon brettcannon May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's what Homebrew's own formula has for CPython, so I just went with it without thinking. It could probably come out in hindsight.

Copy link
Copy Markdown
Member

@brettcannon brettcannon May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#150118

Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They also pass --with-system-expat: https://github.com/Homebrew/homebrew-core/blob/bc720062efe831cb785ffd3b288b6a090ec9d2ac/Formula/p/python%403.14.rb#L136

brew "libedit" if OS.linux?
brew "libffi" if OS.linux?
brew "ncurses" if OS.linux?
brew "unzip" if OS.linux?
brew "zlib-ng-compat" if OS.linux?
Loading