Skip to content

gh-149740: Remove redundant self.empty() check in asyncio.Queue.get() #149741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deadlovelll wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

gh-149740: Remove redundant self.empty() check in asyncio.Queue.get() #149741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/asyncio/queues.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ async def get(self):
if the queue has been shut down immediately.
"""
while self.empty():
if self._is_shutdown and self.empty():
if self._is_shutdown:
Copy link
Copy Markdown
Contributor

@MojoVampire MojoVampire May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just change the loop to while self.empty() and not self._is_shutdown:; get_nowait already rechecks all this stuff when it's called, and would raise the necessary exception for us.

Copy link
Copy Markdown
Member

@picnixz picnixz May 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer keeping this as is, so to keep the symmetry in the get() method.

raise QueueShutDown
getter = self._get_loop().create_future()
self._getters.append(getter)
Expand Down
Loading