gh-144140: Optimize len for frozen dict/set constants in optimizer#149969
Open
lgeiger wants to merge 1 commit into
Open
gh-144140: Optimize len for frozen dict/set constants in optimizer#149969lgeiger wants to merge 1 commit into
lgeiger wants to merge 1 commit into
Conversation
lgeiger
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
lgeiger
commented
May 18, 2026
| "PyStackRef_RefcountOnObject", | ||
| "PyStackRef_TYPE", | ||
| "PyStackRef_True", | ||
| "PyBytes_GET_SIZE", |
Contributor
Author
There was a problem hiding this comment.
As far as I can tell #144142 missed adding PyBytes_GET_SIZE to NON_ESCAPING_FUNCTIONS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends #144142 to also handle
frozensetandfrozendict. Let me know if you think this optimization is not worth it, but it doesn't complicated the code so I don't see any downsides in adding it.