gh-72088: clarify inspect.ismethod and inspect.isfunction (and related) usage with class-level access#150013
Merged
Merged
Conversation
…l access Accessing a method through the class returns a plain function, not a bound method, so ismethod() returns False in that case. Add a note and a cross-reference to the 'instance methods' section of the data model reference to explain this.
…ass-level access Update inspect docs to note the behavioral differences between inspecting instance methods via the class versus via an instance when checking whether an object is a function or a method.
Documentation build overview
|
Member
Hmm, it is quite new, I'd suggest pinging the original author first, they may have just missed Petr's comment. |
Member
|
They also missed the bot comment; I think stale PRs are fair game. |
encukou
reviewed
May 18, 2026
Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou
approved these changes
May 18, 2026
encukou
added
needs backport to 3.13
|
Thanks @stefmolin for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @stefmolin for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @stefmolin and @encukou, I could not cleanly backport this to |
|
GH-150033 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
inspectmodule docs to note the behavioral differences between inspecting instance methods accessed via the class versus via an instance when checking whether an object is a function or a method.This is a continuation from the abandoned PR #146505. In addition to addressing the comments, I noticed the note wasn't correct in the case of class methods and static methods, so I modified the note to explicitly say it applied to instance methods and added a separate sentence for static methods.