Fix tests on PyPy3.11+#756
Merged
JelleZijlstra merged 1 commit intoMay 18, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #756 +/- ##
=======================================
Coverage 97.38% 97.38%
=======================================
Files 3 3
Lines 7773 7773
=======================================
Hits 7570 7570
Misses 203 203
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
(We stopped setting |
JelleZijlstra
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyPy made a recent change that exposes a
__text_signature__attribute on all functions: pypy/pypy@d3fba0e. That broke this test, which assumed thattyping_extensions.NamedTuplewould define__text_signature__buttyping.NamedTuplewould not. Buttyping_extensions.NamedTupleitself hasn't defined__text_signature__for a while, so the special-casing of__text_signature__here is outdated. We can fix the PyPy failure by just simplifying the test and getting rid of the special casing.Fixes #751