chore: export util root APIs#765
Conversation
|
@QDyanbing is attempting to deploy a commit to the React Component Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough更新 devDependency Changes库接口与依赖更新
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-react". (The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@umijs+fabric@3.0.0/node_modules/@umijs/fabric/dist/eslint.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the @rc-component/father-plugin dependency and expands the public API by exporting several new types, utilities, and components, including Portal and PortalWrapper. Feedback suggests aliasing the generic Option type to ToArrayOptions to avoid potential naming collisions and exporting PortalWrapperProps to ensure consistency with other component exports.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #765 +/- ##
=======================================
Coverage 86.42% 86.42%
=======================================
Files 39 39
Lines 1068 1068
Branches 373 388 +15
=======================================
Hits 923 923
Misses 143 143
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid generic Option name collision when importing from package root. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
@rc-component/father-pluginto^2.2.0lib/esdeep imports from rc packages and antd:resetWarned,spyElementPrototype,spyElementPrototypes,Portal,PortalWrapperPrependandOptionfor existing util examplesValidation
npm run compilenpm run lint(passes with existing warnings)npm test -- --runInBandgit diff --checkSummary by CodeRabbit