Do root scanning in scan_vm_specific_roots#24
Merged
Conversation
Collaborator
Author
|
Currently I didn't remove the workaround |
wks
changed the title
peterzhu2118
approved these changes
Apr 8, 2025
wks
force-pushed
the
fix/no-scan-roots-in-mutator-thread
branch
from
a8be598 to
ea97454
Compare
wks
changed the title
We rely on scan_vm_specific_roots to reach all stacks via the following
path:
VM -> ractors -> threads -> fibers -> stacks
wks
force-pushed
the
fix/no-scan-roots-in-mutator-thread
branch
from
ea97454 to
0a6a835
Compare
Collaborator
Author
|
Some run test failures still occur when running with MarkSweep, with some test cases failing with timeouts and others with assertion errors. Since they are reproducible in the main branch, I think they are unlikely related to this PR, and I merged this PR anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We rely on scan_vm_specific_roots to reach all stacks via the following path: