ci: lock down token permissions, attest release binaries, add timeouts#73
Open
mr-raj12 wants to merge 2 commits into
Open
ci: lock down token permissions, attest release binaries, add timeouts#73mr-raj12 wants to merge 2 commits into
mr-raj12 wants to merge 2 commits into
Conversation
Updated the release workflow to include binary attestations and specific version tags for actions.
mr-raj12
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ci.yml:
permissions: contents: readat workflow level. Nothing writes to the repo by default.concurrencygroup: new push to the same branch cancels the old runpathsfilter: README/LICENSE changes no longer trigger CItimeout-minutes: 20so a stuck Nix install doesn't eat runner time for hoursrelease.yml:
actions/attest-build-provenanceafter each of the 4 platform builds. Links each binary to this exact commit so users can verify what they downloaded came from this workflow.id-token: writeandattestations: writeadded to permissions (needed for OIDC signing)timeout-minutes: 45Why
Anyone downloading a release binary today has no way to check it wasn't swapped after the build. The attestation steps fix that. SHA pinning and a read-only default token were both missing, and OSSF Scorecard flags both.