Skip to content

Security: Unsandboxed JSR223 Script Execution Enables Arbitrary Code Execution #858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nam0101 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Security: Unsandboxed JSR223 Script Execution Enables Arbitrary Code Execution #858

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions APIJSONORM/src/main/java/apijson/orm/script/JSR223ScriptExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,34 @@ public abstract class JSR223ScriptExecutor<T, M extends Map<String, Object>, L e

@Override
public ScriptExecutor<T, M, L> init() {
ScriptEngineManager scriptEngineManager = new ScriptEngineManager();
scriptEngine = scriptEngineManager.getEngineByName(scriptEngineName());
scriptEngine = createScriptEngine();
return this;
}

protected ScriptEngine createScriptEngine() {
String name = scriptEngineName();
if ("nashorn".equalsIgnoreCase(name) || "javascript".equalsIgnoreCase(name)
|| "js".equalsIgnoreCase(name) || "ecmascript".equalsIgnoreCase(name)) {
try {
Class<?> factoryClass = Class.forName("jdk.nashorn.api.scripting.NashornScriptEngineFactory");
Class<?> filterClass = Class.forName("jdk.nashorn.api.scripting.ClassFilter");
Object filter = java.lang.reflect.Proxy.newProxyInstance(
filterClass.getClassLoader(),
new Class<?>[]{filterClass},
(proxy, method, methodArgs) -> isClassExposureAllowed((String) methodArgs[0]));
Object factory = factoryClass.getDeclaredConstructor().newInstance();
return (ScriptEngine) factoryClass.getMethod("getScriptEngine", filterClass).invoke(factory, filter);
} catch (Throwable e) {
Log.e(TAG, "create sandboxed Nashorn engine failed, falling back: " + e);
}
}
return new ScriptEngineManager().getEngineByName(name);
}

protected boolean isClassExposureAllowed(String className) {
return false;
}

protected abstract String scriptEngineName();

protected abstract Object extendParameter(AbstractFunctionParser<T, M, L> parser, Map<String, Object> currentObject, String methodName, Object[] args);
Expand Down